Enable repeated search in DocumentUnitSearchEntryForm #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is WIP. RISDEV-4003
RISDEV-4003 In order to avoid having too many conditionals and variables (e.g. isIdenticalSearch), this solution decouples the search completely from the route. The route is still pushed to the router, in order to maintain the search on reload, but now the search is always triggered, when the search button is clicked and on first mount.
This search has been triggered twice RISDEV-4003
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the technical reviewer:
I need some hint for the test which works when I run all tests in documentUnitSearchEntryForm.spec.ts at once but which fails when started individually.
RISDEV-4003