refactor: resolve a bunch of code smells

RISDEV-3828
digitalservicebund · May 23, 2024 · 1703e4e · 1703e4e
1 parent e5b03f4
commit 1703e4e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/...bund/digitalservice/ris/norms/adapter/input/restapi/mapper/ElementResponseMapperTest.java b/...bund/digitalservice/ris/norms/adapter/input/restapi/mapper/ElementResponseMapperTest.java
@@ -4,9 +4,10 @@
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
 import de.bund.digitalservice.ris.norms.utils.XmlMapper;
+import java.util.NoSuchElementException;
 import org.junit.jupiter.api.Test;
 
-public class ElementResponseMapperTest {
+class ElementResponseMapperTest {
   @Test
   void convertsAnArticleNode() {
     // Given
@@ -96,7 +97,7 @@ void convertsAnArticleWithoutTitleToNode() {
     var output = ElementResponseMapper.fromElementNode(node);
 
     // Then
-    assertThat(output.getTitle()).isEqualTo("");
+    assertThat(output.getTitle()).isEmpty();
     assertThat(output.getEid()).isEqualTo("hauptteil-1_para-1");
     assertThat(output.getType()).isEqualTo("article");
   }
@@ -177,7 +178,7 @@ void convertsAnArbitraryNode() {
     var output = ElementResponseMapper.fromElementNode(node);
 
     // Then
-    assertThat(output.getTitle()).isEqualTo("");
+    assertThat(output.getTitle()).isEmpty();
     assertThat(output.getEid()).isEqualTo("random-1");
     assertThat(output.getType()).isEqualTo("someRandomNode");
   }
@@ -195,6 +196,7 @@ void throwsWhenConvertingANodeWithoutEid() {
             """);
 
     // When
-    assertThatThrownBy(() -> ElementResponseMapper.fromElementNode(node));
+    assertThatThrownBy(() -> ElementResponseMapper.fromElementNode(node))
+        .isInstanceOf(NoSuchElementException.class);
   }
 }
diff --git a/...service/ris/norms/integration/adapter/input/restapi/ElementControllerIntegrationTest.java b/...service/ris/norms/integration/adapter/input/restapi/ElementControllerIntegrationTest.java
@@ -26,7 +26,6 @@ void cleanUp() {
     normRepository.deleteAll();
   }
 
-  // TODO Hannes: Adjust OpenAPI documentation
   @Nested
   class GetElement {
     @Test
@@ -261,9 +260,6 @@ void itReturnsOnlyTheElementsMatchingTheGivenAmendingLaw() throws Exception {
               + "&type=article"
               + "&type=conclusions"
               + "&amendedBy=eli/bund/bgbl-1/2017/s815/1995-03-15/1/deu/regelungstext-1"; // second
-      // mod
-      // source
-      // eli
 
       // when
       mockMvc