Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-rails from 2.4.1 to 2.5.1 #140

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps rubocop-rails from 2.4.1 to 2.5.1.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.5.1

Bug fixes

  • #213: Fix a false positive for Rails/UniqueValidationWithoutIndex when using conditions. (@sunny)
  • #215: Fix a false positive for Rails/UniqueValidationWithoutIndex when using Expression Indexes. (@koic)
  • #214: Fix an error for Rails/UniqueValidationWithoutIndexwhen a table has no column definition. (@koic)
  • #221: Make Rails/UniqueValidationWithoutIndex aware of add_index in db/schema.rb. (@koic)

Changes

  • #223: Mark Rails/ApplicationController, Rails/ApplicationJob, Rails/ApplicationMailer, and Rails/ApplicationRecord as unsafe autocorrect. (@hoshinotsuyoshi)

RuboCop Rails 2.5.0

New features

  • #197: Add Rails/UniqueValidationWithoutIndex cop. (@pocke)
  • #208: Add new Rails/IndexBy and Rails/IndexWith cops. (@djudd, @eugeneius)
  • #150: Add EnforcedStyle: refute for Rails/RefuteMethods cop. (@koic)

Bug fixes

  • #180: Fix a false positive for HttpPositionalArguments when using get method with :to option. (@koic)
  • #193: Make Rails/EnvironmentComparison aware of Rails.env is used in RHS or when != is used for comparison. (@koic)
  • #205: Make Rails/ReversibleMigration aware of :to_table option of remove_foreign_key. (@joshpencheon)
  • #207: Fix a false positive for Rails/RakeEnvironment when using Capistrano. (@sinsoku)

RuboCop Rails 2.4.2

Bug fixes

  • #184: Fix Rake/Environment to allow task with no block. (@hanachin)
  • #122: Fix Exclude paths that were not inherited. (@koic)
  • #187: Fix an issue that excluded files in rubocop-rails did not work. (@sinsoku)
  • #190: Fix Rails/SaveBang when return value is checked immediately. (@jas14)
Changelog

Sourced from rubocop-rails's changelog.

2.5.1 (2020-04-02)

Bug fixes

  • #213: Fix a false positive for Rails/UniqueValidationWithoutIndex when using conditions. ([@sunny][])
  • #215: Fix a false positive for Rails/UniqueValidationWithoutIndex when using Expression Indexes. ([@koic][])
  • #214: Fix an error for Rails/UniqueValidationWithoutIndexwhen a table has no column definition. ([@koic][])
  • #221: Make Rails/UniqueValidationWithoutIndex aware of add_index in db/schema.rb. ([@koic][])

Changes

  • #223: Mark Rails/ApplicationController, Rails/ApplicationJob, Rails/ApplicationMailer, and Rails/ApplicationRecord as unsafe autocorrect. ([@hoshinotsuyoshi][])

2.5.0 (2020-03-24)

New features

  • #197: Add Rails/UniqueValidationWithoutIndex cop. ([@pocke][])
  • #208: Add new Rails/IndexBy and Rails/IndexWith cops. ([@djudd][], [@eugeneius][])
  • #150: Add EnforcedStyle: refute for Rails/RefuteMethods cop. ([@koic][])

Bug fixes

  • #180: Fix a false positive for HttpPositionalArguments when using get method with :to option. ([@koic][])
  • #193: Make Rails/EnvironmentComparison aware of Rails.env is used in RHS or when != is used for comparison. ([@koic][])
  • #205: Make Rails/ReversibleMigration aware of :to_table option of remove_foreign_key. ([@joshpencheon][])
  • #207: Fix a false positive for Rails/RakeEnvironment when using Capistrano. ([@sinsoku][])

2.4.2 (2020-01-26)

Bug fixes

  • #184: Fix Rake/Environment to allow task with no block. ([@hanachin][])
  • #122: Fix Exclude paths that were not inherited. ([@koic][])
  • #187: Fix an issue that excluded files in rubocop-rails did not work. ([@sinsoku][])
  • #190: Fix Rails/SaveBang when return value is checked immediately. ([@jas14][])
Commits
  • 7a33464 Cut 2.5.1
  • 32791a6 Merge pull request #223 from hoshinotsuyoshi/application-controller-unsafe
  • a1aa7d5 Mark Rails/ApplicationController and similar cops as unsafe autocorrect
  • ad4e97d Merge pull request #222 from koic/make_unique_validation_without_index_aware_...
  • 3fa9c7c [Fix #221] Make Rails/UniqueValidationWithoutIndex aware of add_index
  • 3ba2b30 Merge pull request #218 from koic/fix_error_for_unique_validation_without_index
  • fdeeba5 [Fix #214] Fix an error for Rails/UniqueValidationWithoutIndex
  • 789a8f2 Merge pull request #217 from koic/fix_a_false_positive_for_unique_validation_...
  • ac766e3 [Fix #215] Fix a false positive for Rails/UniqueValidationWithoutIndex
  • e952888 Tweak a changelog entry
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [rubocop-rails](https://github.com/rubocop-hq/rubocop-rails) from 2.4.1 to 2.5.1.
- [Release notes](https://github.com/rubocop-hq/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.4.1...v2.5.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Apr 6, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2a66a73 on dependabot/bundler/rubocop-rails-2.5.1 into e9ba267 on master.

@dependabot-preview
Copy link
Contributor Author

Superseded by #141.

@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/rubocop-rails-2.5.1 branch April 13, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant