Release/1.5.7 #194
Release/1.5.7 #194
Conversation
silavjy
commented
Jan 20, 2023
silavjy
commented
- Release/1.5.7 #193 which includes
- Enhance pre-flight check on EC-Switch-SECLOG.py script #191
- Update AWSCloudFormationStackSetExecutionRole to include itself as principal #190
- Remove non SSL access on artefacts bucket #192
* upgraded lambda runtime python to 3.9 * changed SSL permissions set * as principal all buckets * added version and manifest * removed action from lambda code bucket policy PutObjectAcl * added update request type Update event to password policy lambda * stack changes for AWSConfigRole to AWS_ConfigRole replacement
* Updated runtime engine for LandingZoneLocalSNSNotificationForwarder to python 3.9 * created manifest for 1.5.5
* Update Readme.md documentation. * Deleted EC-Create-Account.sh (deprecated, not valid anymore) * Added switch SECLOG scripts * Added Delete landing zone script * Preparing the release
…aggregator hasn't been created
…cript if status is not in 'CREATE_COMPLETE','UPDATE_COMPLETE'
| @@ -150,6 +150,11 @@ def main(argv): | |||
| print("Exiting...") | |||
| sys.exit(1) | |||
|
|
|||
| if pre_flight_cfn(account_session) == False: | |||
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
The == and != operators use the compared objects' __eq__ method to test if they are equal. To check if an object is a singleton, such as None, we recommend that you use the is identity comparison operator.
Similar issue at line numbers 183 and 202.
| def pre_flight_cfn(session): | ||
| status = True | ||
| cfn = session.client('cloudformation') | ||
| response = cfn.describe_stacks() |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
The API method describe_stacks returns paginated results instead of all results. Consider using the pagination API or checking one of the following keys in the response to verify that all results were returned: IsTruncated, NextToken.
|
We identified new issues on unchanged lines of code. Navigate to the Amazon CodeGuru Reviewer console to view the recommendations to fix them. |
| @@ -150,6 +150,12 @@ def main(argv): | |||
| print("Exiting...") | |||
| sys.exit(1) | |||
|
|
|||
| if pre_flight_cfn(account_session) == False: | |||
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
The == and != operators use the compared objects' __eq__ method to test if they are equal. To check if an object is a singleton, such as None, we recommend that you use the is identity comparison operator.
Similar issue at line numbers 184 and 203.
