rsync': undefined method success?' for nil:NilClass

[edwinvdgraaf]

On line: https://github.com/DigitPaint/roger/blob/master/lib/roger/release/finalizers/rsync.rb#L68

CodeClimate coverage
https://codeclimate.com/github/DigitPaint/roger/coverage/5587d85dd86bab7e2601da4d

How is the $CHILD_STATUS set?

[flurin]

Hummm. That's supposed to be a magic global from ruby. I think the rubocop autocorrector did something to this

On 22 jun. 2015, at 13:45, Edwin van der Graaf notifications@github.com wrote:

On line: https://github.com/DigitPaint/roger/blob/master/lib/roger/release/finalizers/rsync.rb#L68

CodeClimate coverage
https://codeclimate.com/github/DigitPaint/roger/coverage/5587d85dd86bab7e2601da4d

How is the $CHILD_STATUS set?

—
Reply to this email directly or view it on GitHub.

[edwinvdgraaf]

Aye.

306a84b#diff-d12e35b68c9b91f475a6ab3ad7d3b30aL55

-        unless $?.success?
-          raise RuntimeError, "Rsync failed.\noutput:\n #{output}"
-        end
+        fail "Rsync failed.\noutput:\n #{output}" unless $CHILD_STATUS.success?

[flurin]

What ruby version does this happen? I tested it in ruby-1.9.3, ruby-2.2.0 and there doesn't seem to be an issue

[flurin]

Can you see if the tests in PR #37 branch also break for you?

[flurin]

Fixed in #37