Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PS2: Scanner broken on invalid character #100

Closed
Maelstromeous opened this issue May 25, 2024 · 0 comments · Fixed by #137
Closed

PS2: Scanner broken on invalid character #100

Maelstromeous opened this issue May 25, 2024 · 0 comments · Fixed by #137
Assignees
@Maelstromeous
Labels
bug Something isn't working

Comments

@Maelstromeous
Copy link
Collaborator

5429423912993736641 character does not exist and has broken the scanner
@Maelstromeous Maelstromeous added the bug Something isn't working label May 25, 2024
@Maelstromeous Maelstromeous self-assigned this May 25, 2024
Maelstromeous added a commit that referenced this issue May 30, 2024
@Maelstromeous
fix #100: Properly create promises for each character, previously we …
f3086d7 
…were just executing the non promise in place, and effectively running the query twice.
@Maelstromeous Maelstromeous mentioned this issue May 30, 2024
Merged
Maelstromeous added a commit that referenced this issue May 30, 2024
@Maelstromeous
fix #100: Made linter happy
07c6eb3
Maelstromeous added a commit that referenced this issue May 30, 2024
@Maelstromeous
fix #100: Properly create promises for each character, previously we … (
b9c4a32 
#137)

* fix #100: Properly create promises for each character, previously we were just executing the non promise in place, and effectively running the query twice.

* fix #100: Made linter happy
Maelstromeous added a commit that referenced this issue May 30, 2024
@Maelstromeous
fix #100: Try again to fix the scanner
eec6d07
Maelstromeous added a commit that referenced this issue May 30, 2024
@Maelstromeous
fix #100: Try again to fix the scanner (#138)
a9b3e47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Maelstromeous Maelstromeous

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #100: Properly create promises for each character, previously we … dignityofwar/diglet-bot
1 participant
@Maelstromeous