Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsHamiltonianDigraph attempts to modify immutable blists #191

Closed
wilfwilson opened this issue Apr 10, 2019 · 0 comments
Closed

IsHamiltonianDigraph attempts to modify immutable blists #191

wilfwilson opened this issue Apr 10, 2019 · 0 comments
Assignees
Labels
bug A label for issues that are bugs

Comments

@wilfwilson
Copy link
Collaborator

As highlighted in a recent handy Travis CRON job, IsHamiltonianDigraph modifies mutable lists. This would mean that the attribute BooleanAdjacencyMatrix would potentially by modified by running IsHamiltonianDigraph. That this didn't previously raise an error was a bug in GAP, which has just been fixed in GAP master branch in gap-system/gap#3392. Now we get the following error:

gap> g := Digraph([[3], [3], [1, 2]]);
<digraph with 3 vertices, 4 edges>
gap> IsHamiltonianDigraph(g);
Error, IntersectBlist: <blist1> must be a mutable boolean list (not a list (boolean,imm)) in
  IntersectBlist( tempblist, adjmatrix[j] );
@wilfwilson wilfwilson added the bug A label for issues that are bugs label Apr 10, 2019
@wilfwilson wilfwilson self-assigned this Apr 10, 2019
@wilfwilson wilfwilson added the resolved-pending-merge A label for issues that are resolved in a PR that is not yet merged. label Apr 10, 2019
@james-d-mitchell james-d-mitchell added the resolved-pending-release A label for issues that have been resolved and that can be closed when a new version is released. label Apr 10, 2019
@wilfwilson wilfwilson removed the resolved-pending-merge A label for issues that are resolved in a PR that is not yet merged. label Apr 10, 2019
@wilfwilson wilfwilson removed the resolved-pending-release A label for issues that have been resolved and that can be closed when a new version is released. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A label for issues that are bugs
Projects
None yet
Development

No branches or pull requests

2 participants