integrate (special case for resources with POST operations that do no…

…t expect any input) logic into validateRootPath

openapi/openapi_v2_spec_analyser.go

@@ -344,15 +344,17 @@ func (specAnalyser *specV2Analyser) validateRootPath(resourcePath string) (strin
 	resourceRootPostSchemaDef, err := specAnalyser.getBodyParameterBodySchema(resourceRootPostOperation)
 	if err != nil {
 		bodyParam := specAnalyser.bodyParameterExists(resourceRootPostOperation)
+		// Use case where resource does not expect any input as part of the POST root operation, and only produces computed properties
 		if bodyParam == nil {
-			resourceSchema, _ := specAnalyser.getSuccessfulResponseDefinition(resourceRootPostOperation) // TODO: implement this
-			err := specAnalyser.validateResourceSchemaDefWithOptions(resourceSchema, true)
+			resourceSchema, err := specAnalyser.getSuccessfulResponseDefinition(resourceRootPostOperation)
 			if err != nil {
-				return "", nil, nil, fmt.Errorf("resource root path '%s' POST operation validation error: %s", resourceRootPath, err)
+				return "", nil, nil, fmt.Errorf("resource root path '%s' POST operation (without body parameter) error: %s", resourceRootPath, err)
 			}
-			// TODO: if we have reached this poiunt, that means that the root path should also be considered valid even though the post does not contain a body param. Hence, the resourceRootPostSchemaDef should instead be assigned to the model returned by getSuccessfulResponseDefinition
-			// TODO: assign resourceRootPostSchemaDef = resourceSchema
-			// TODO: return resourceRootPath, &resourceRootPathItem, resourceRootPostSchemaDef, nil
+			err = specAnalyser.validateResourceSchemaDefWithOptions(resourceSchema, true)
+			if err != nil {
+				return "", nil, nil, fmt.Errorf("resource root path '%s' POST operation (without body parameter) validation error: %s", resourceRootPath, err)
+			}
+			return resourceRootPath, &resourceRootPathItem, resourceSchema, nil
 		}
 		return "", nil, nil, fmt.Errorf("resource root path '%s' POST operation validation error: %s", resourceRootPath, err)
 	}

openapi/openapi_v2_spec_analyser_test.go

@@ -1707,7 +1707,7 @@ definitions:
 		})
 	})
 
-	Convey("Given an apiSpecAnalyser with a resource instance path such as '/users/{id}' but the root is missing the 'body' parameter", t, func() {
+	Convey("Given an apiSpecAnalyser with a resource instance path such as '/users/{id}' but the root is missing the 'body' parameter AND it's not a compatible resource without input", t, func() {
 		swaggerContent := `swagger: "2.0"
 paths:
   /users:
@@ -1747,7 +1747,7 @@ definitions:
 				So(err, ShouldNotBeNil)
 			})
 			Convey("And the error message should be", func() {
-				So(err.Error(), ShouldContainSubstring, "resource root path '/users' POST operation validation error: resource root operation missing the body parameter")
+				So(err.Error(), ShouldContainSubstring, "resource root path '/users' POST operation (without body parameter) validation error: resource schema contains properties that are not just read only")
 			})
 		})
 	})