Skip to content

Commit

Permalink
Pump Terraform SDK version to 2.0.0
Browse files Browse the repository at this point in the history
- Terraform Plugin SDK v2 Upgrade Guide: https://www.terraform.io/docs/extend/guides/v2-upgrade-guide.html#version-2-of-the-module
- Updated readme to include compatible GO version for SDK 2.0 https://github.com/hashicorp/terraform-plugin-sdk#go-compatibility
  • Loading branch information
dikhan committed Dec 17, 2020
1 parent 5d335a8 commit e2bdefe
Show file tree
Hide file tree
Showing 42 changed files with 378 additions and 66 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ rather than the tooling around it.
### Requirements

- [Terraform](https://www.terraform.io/downloads.html) v0.12.0 (to execute the terraform provider plugin)
- [Go](https://golang.org/doc/install) 1.12.4 (to build the provider plugin)
- [Go](https://golang.org/doc/install) >=1.14 (to build the provider plugin)
- This project uses [go modules](https://github.com/golang/go/wiki/Modules) for dependency management
- [Docker](https://www.docker.com/) 17.09.0-ce (to run service provider example)
- [Docker-compose](https://docs.docker.com/compose/) 1.16.1 (to run service provider example)
Expand Down
21 changes: 11 additions & 10 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,18 @@ require (
github.com/go-openapi/spec v0.19.0
github.com/go-openapi/strfmt v0.0.0-20171222154016-4dd3d302e100 // indirect
github.com/goadesign/goa v0.0.0-20180629224717-ed6ccb1eb93a
github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e // indirect
github.com/google/go-github v17.0.0+incompatible // indirect
github.com/google/go-querystring v1.0.0 // indirect
github.com/google/gxui v0.0.0-20151028112939-f85e0a97b3a4 // indirect
github.com/gopherjs/gopherjs v0.0.0-20190915194858-d3ddacdb130f // indirect
github.com/gorilla/context v1.1.1 // indirect
github.com/gorilla/mux v1.6.2
github.com/hashicorp/go-uuid v1.0.1
github.com/hashicorp/golang-lru v0.5.1 // indirect
github.com/hashicorp/hcl v0.0.0-20171017181929-23c074d0eceb // indirect
github.com/hashicorp/terraform-plugin-sdk v1.1.0
github.com/hashicorp/terraform-plugin-sdk v1.16.0
github.com/hashicorp/terraform-plugin-sdk/v2 v2.0.0
github.com/iancoleman/strcase v0.0.0-20180726023541-3605ed457bf7
github.com/inconshreveable/mousetrap v1.0.0 // indirect
github.com/jtolds/gls v4.20.0+incompatible // indirect
Expand All @@ -40,18 +43,16 @@ require (
github.com/smartystreets/assertions v0.0.0-20180927180507-b2de0cb4f26d
github.com/smartystreets/goconvey v0.0.0-20180222194500-ef6db91d284a
github.com/spf13/cobra v0.0.3
github.com/stretchr/testify v1.3.0
github.com/stretchr/testify v1.4.0
github.com/stvp/go-udp-testing v0.0.0-20191102171040-06b61409b154
github.com/yuin/goldmark v1.1.33 // indirect
github.com/zach-klippenstein/goregen v0.0.0-20160303162051-795b5e3961ea // indirect
golang.org/x/crypto v0.0.0-20200709230013-948cd5f35899 // indirect
golang.org/x/lint v0.0.0-20200302205851-738671d3881b // indirect
golang.org/x/net v0.0.0-20200707034311-ab3426394381 // indirect
golang.org/x/sys v0.0.0-20200625212154-ddb9806d33ae // indirect
golang.org/x/text v0.3.3 // indirect
golang.org/x/tools v0.0.0-20200717024301-6ddee64345a6 // indirect
golang.org/x/crypto v0.0.0-20200820211705-5c72a883971a // indirect
golang.org/x/net v0.0.0-20200923182212-328152dc79b1 // indirect
golang.org/x/sys v0.0.0-20200923182605-d9f96fdee20d // indirect
golang.org/x/tools v0.0.0-20200924224222-8d73f17870ce // indirect
google.golang.org/appengine v1.6.6 // indirect
gopkg.in/mgo.v2 v2.0.0-20160818020120-3f83fa500528 // indirect
gopkg.in/yaml.v2 v2.2.2
gopkg.in/yaml.v2 v2.2.4
)

replace git.apache.org/thrift.git => github.com/apache/thrift v0.0.0-20180902110319-2566ecd5d999
311 changes: 311 additions & 0 deletions go.sum

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions main.go
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
package main

import (
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"log"

"fmt"
"github.com/dikhan/terraform-provider-openapi/openapi"
"github.com/dikhan/terraform-provider-openapi/openapi/version"
"github.com/hashicorp/terraform-plugin-sdk/plugin"
"github.com/hashicorp/terraform-plugin-sdk/terraform"
"github.com/hashicorp/terraform-plugin-sdk/v2/plugin"
"os"
"regexp"
)
Expand Down
2 changes: 1 addition & 1 deletion openapi/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"strconv"

"github.com/dikhan/terraform-provider-openapi/openapi/openapierr"
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
)

func checkHTTPStatusCode(openAPIResource SpecResource, res *http.Response, expectedHTTPStatusCodes []int) error {
Expand Down
2 changes: 1 addition & 1 deletion openapi/common_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"testing"

"github.com/go-openapi/spec"
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
. "github.com/smartystreets/goconvey/convey"
"github.com/stretchr/testify/assert"
)
Expand Down
2 changes: 1 addition & 1 deletion openapi/data_source_factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"net/http"
"strconv"

"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
)

const dataSourceFilterPropertyName = "filter"
Expand Down
2 changes: 1 addition & 1 deletion openapi/data_source_factory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (

"github.com/stretchr/testify/require"

"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/stretchr/testify/assert"
)

Expand Down
2 changes: 1 addition & 1 deletion openapi/data_source_instance_factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"fmt"
"net/http"

"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
)

const dataSourceInstanceIDProperty = "id"
Expand Down
2 changes: 1 addition & 1 deletion openapi/data_source_instance_factory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package openapi

import (
"errors"
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"net/http"
Expand Down
2 changes: 1 addition & 1 deletion openapi/helperutils_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package openapi

import (
"encoding/json"
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/stretchr/testify/assert"
"io/ioutil"
"log"
Expand Down
2 changes: 1 addition & 1 deletion openapi/openapi_spec_resource_schema_definition.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package openapi
import (
"fmt"

"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
)

// SpecSchemaDefinitionProperties defines a collection of schema definition properties
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"reflect"

"github.com/dikhan/terraform-provider-openapi/openapi/terraformutils"
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
)

// schemaDefinitionPropertyType defines the type of a property
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (

"github.com/stretchr/testify/assert"

"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"

. "github.com/smartystreets/goconvey/convey"
)
Expand Down
2 changes: 1 addition & 1 deletion openapi/openapi_spec_resource_schema_definition_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"errors"
"testing"

"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/stretchr/testify/assert"

. "github.com/smartystreets/goconvey/convey"
Expand Down
2 changes: 1 addition & 1 deletion openapi/plugin_config_telemetry.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package openapi

import "github.com/hashicorp/terraform-plugin-sdk/helper/schema"
import "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"

// TelemetryProviderConfiguration defines the struct type that specific telemetry providers can configure based on the
// resource data received in GetTelemetryProviderConfiguration. The struct serves as a way to document in the metric
Expand Down
2 changes: 1 addition & 1 deletion openapi/plugin_config_telemetry_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package openapi

import (
"fmt"
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"log"
"time"
)
Expand Down
2 changes: 1 addition & 1 deletion openapi/plugin_config_telemetry_provider_graphite.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"errors"
"fmt"
"github.com/DataDog/datadog-go/statsd"
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"log"
"strings"
)
Expand Down
2 changes: 1 addition & 1 deletion openapi/plugin_config_telemetry_provider_httpendpoint.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"fmt"
"github.com/asaskevich/govalidator"
"github.com/dikhan/terraform-provider-openapi/openapi/version"
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"log"
"net/http"
"runtime"
Expand Down
2 changes: 1 addition & 1 deletion openapi/plugin_config_telemetry_provider_stub.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package openapi

import "github.com/hashicorp/terraform-plugin-sdk/helper/schema"
import "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"

type telemetryProviderStub struct {
validationError error
Expand Down
2 changes: 1 addition & 1 deletion openapi/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"fmt"
"log"

"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
)

// ProviderOpenAPI defines the struct for the OpenAPI Terraform Provider
Expand Down
2 changes: 1 addition & 1 deletion openapi/provider_configuration.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package openapi

import (
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
)

const providerPropertyRegion = "region"
Expand Down
6 changes: 3 additions & 3 deletions openapi/provider_configuration_endpoints.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import (
"bytes"
"fmt"
"github.com/dikhan/terraform-provider-openapi/openapi/openapiutils"
"github.com/hashicorp/terraform-plugin-sdk/helper/hashcode"
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/hashcode"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
)

type providerConfigurationEndPoints struct {
Expand Down Expand Up @@ -55,7 +55,7 @@ func (p *providerConfigurationEndPoints) endpointsToHash(resources []string) sch
for _, name := range resources {
buf.WriteString(fmt.Sprintf("%s-", m[name].(string)))
}
return hashcode.String(buf.String())
return String(buf.String())
}
}

Expand Down
6 changes: 3 additions & 3 deletions openapi/provider_configuration_endpoints_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ package openapi
import (
"bytes"
"fmt"
"github.com/hashicorp/terraform-plugin-sdk/helper/hashcode"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/hashcode"
"testing"

"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"

. "github.com/smartystreets/goconvey/convey"
)
Expand Down Expand Up @@ -58,7 +58,7 @@ func TestEndpointsToHash(t *testing.T) {
m[resourceName] = "something to get the string representation from"
var buf bytes.Buffer
buf.WriteString(fmt.Sprintf("%s-", m[resourceName].(string)))
So(schemaSetFunction(m), ShouldEqual, hashcode.String(buf.String()))
So(schemaSetFunction(m), ShouldEqual, String(buf.String()))
})
})
})
Expand Down
2 changes: 1 addition & 1 deletion openapi/provider_factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
"log"

"github.com/dikhan/http_goclient"
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
)

type providerFactory struct {
Expand Down
2 changes: 1 addition & 1 deletion openapi/provider_factory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"errors"
"fmt"
"github.com/dikhan/terraform-provider-openapi/openapi/version"
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/stretchr/testify/assert"
"io/ioutil"
"net/http"
Expand Down
2 changes: 1 addition & 1 deletion openapi/provider_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"os"
"testing"

"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"

. "github.com/smartystreets/goconvey/convey"
)
Expand Down
4 changes: 2 additions & 2 deletions openapi/resource_factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import (
"time"

"github.com/dikhan/terraform-provider-openapi/openapi/openapierr"
"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
)

type resourceFactory struct {
Expand Down
2 changes: 1 addition & 1 deletion openapi/resource_factory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
"time"

"encoding/json"
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
. "github.com/smartystreets/goconvey/convey"
)

Expand Down
2 changes: 1 addition & 1 deletion openapi/terraformutils/terraform_utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

"github.com/iancoleman/strcase"

"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/mitchellh/go-homedir"
)

Expand Down
2 changes: 1 addition & 1 deletion openapi/terraformutils/terraform_utils_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"strings"
"testing"

"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
. "github.com/smartystreets/goconvey/convey"
)

Expand Down
6 changes: 3 additions & 3 deletions tests/e2e/gray_box_cdns_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ import (
"strings"
"testing"

"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/stretchr/testify/require"

"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/terraform"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"

"github.com/dikhan/terraform-provider-openapi/openapi"
"github.com/stretchr/testify/assert"
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/gray_box_plugin_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import (
"net/http/httptest"
"testing"

"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/terraform"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"

"github.com/dikhan/terraform-provider-openapi/openapi"
"github.com/stretchr/testify/assert"
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/provider_plugin_configuration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ package e2e
import (
"fmt"
"github.com/dikhan/terraform-provider-openapi/openapi"
"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/terraform"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
"github.com/stretchr/testify/assert"
"io/ioutil"
"log"
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/resources_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import (
"regexp"
"testing"

"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/terraform"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"

"github.com/dikhan/terraform-provider-openapi/openapi"
"github.com/stretchr/testify/assert"
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/test_api_utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ package e2e

import (
"fmt"
"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/terraform"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
"github.com/stretchr/testify/assert"
"net/http"
"strings"
Expand Down
Loading

0 comments on commit e2bdefe

Please sign in to comment.