Feature/post opeartion with no inputs #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eation) is not considered terraform compatible
…ing post body operation - test is currently failing, need to get to green state - updated convey statements to match actual method being called
…on (bodyParameterExists) - use the first body parameter returned - no longer check for multiple body params - remove test case checking for multiple body params
- refactor bodyParameterExists to no longer return error - refactor tests with new bodyParameterExists signature - add tests for validateResourceSchemaDefWithOptions
- only testing happy path - moved other test cases to TestValidateResourceSchemaDefWithOptions
- added unit tests
…t expect any input) logic into validateRootPath
- added delete operation as the int test fw requires the delete operation to be implemented... - fixed type format issue int vs string
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
==========================================
+ Coverage 88.84% 88.91% +0.06%
==========================================
Files 51 51
Lines 3047 3066 +19
==========================================
+ Hits 2707 2726 +19
Misses 219 219
Partials 121 121
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Please add as many details as possible about the change here. Does this Pull Request resolve any open issue? If so, please make sure to link to that issue:
Fixes: #171
Type of change
What type of change does your code introduce to the provider? Please put an
x(w/o heading/trailing white spaces)in the boxes that apply:
Checklist
Please put an
x(w/o heading/trailing white spaces) in the boxes that apply: