Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounds error when tiling #1094

Closed
athas opened this issue Aug 21, 2020 · 2 comments
Closed

Bounds error when tiling #1094

athas opened this issue Aug 21, 2020 · 2 comments

Comments

@athas
Copy link
Member

athas commented Aug 21, 2020

We may generate out-of-bounds reads when doing 2D tiling for inputs that are smaller in the outer dimension than the tile size. E.g. a standard matrix multiplication will have problems when given inputs of size [31][32] by [32][32].

@athas
Copy link
Member Author

athas commented Aug 21, 2020

There is a straightforward fix for this. Unfortunately, it will reduce the performance of 2D block tiled kernels, like matrix multiplication. I think we just have to accept that for now, and see if we can recover the performance later.

@athas
Copy link
Member Author

athas commented Aug 21, 2020

The slowdown is about 2%.

@athas athas closed this as completed in 0a7f58d Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant