Prevent race condition (updated for style rules) #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
|
OK I have to apologize, because I apparently made a typo ("9" where a "(" should be, on line 287). |
|
@nk53 |
|
This fix prevents the vulnerability #34 to overwrite files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I test this on my machine, the last two processes to read a chunk will occasionally both attempt to write the combined file.
Cakephp can use locking to ensure no more than one process writes to a file at a time, however it does not guarantee that only one process writes to a file at all. For this, we need to open the file with the
O_EXCLflag (xin PHP).This pull request ensures only one process will write to
destFile.