Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane boundaries are different #26

Open
razasy299 opened this issue Jan 28, 2020 · 1 comment
Open

Plane boundaries are different #26

razasy299 opened this issue Jan 28, 2020 · 1 comment

Comments

@razasy299
Copy link

My output
my_output
Expected output
ambient-diffuse-specular
The plane boundaries are solid lines in my output. I have checked all my formulas and they match the book. Any advice on how to debug this?

@darren-moore
Copy link

My guess is that it's the diffuse shading. I'd turn off everything except for the diffuse to debug. Make sure you're normalizing correctly (#29), but the sphere looks okay.
Check that you're factoring in the light color/intensity for the diffuse and specular components too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants