Update es-cec-input.py #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
es-cec-input_kodi_18_fix
Kodi v18 changed the name of the Kodi process. Thus, es-cec-input did not detect that Kodi was running. This cause a double click effect when using the directional keys. By changing the find command to only look for 'kodi', it fixes the problem in Kodi v18 without breaking Kodi v17. Using a less precise value for the Kodi process name in theory could make it more susceptible to naming collisions, it seems that changing process names for future Kodi versions is a more likely problem.Kodi v18 changed the name of the Kodi process. Thus, es-cec-input did not detect that Kodi was running. This cause a double click effect when using the directional keys. By changing the find command to only look for 'kodi', it fixes the problem in Kodi v18 without breaking Kodi v17. Using a less precise value for the Kodi process name in theory could make it more susceptible to naming collisions, it seems that changing process names for future Kodi versions is a more likely problem.Kodi v18 changed the name of the Kodi process. Thus, es-cec-input did not detect that Kodi was running. This cause a double click effect when using the directional keys. By changing the find command to only look for 'kodi', it fixes the problem in Kodi v18 without breaking Kodi v17. Using a less precise value for the Kodi process name in theory could make it more susceptible to naming collisions, it seems that changing process names for future Kodi versions is a more likely problem.