Cocoapods spec #11
Closed
Cocoapods spec #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Appsido I think you have to make the convenience init of the UIAlertController public. Otherwise it will not compile. |
|
@ltblueberry0 You may be right. I'll check that and more probably declare as open may be better than public |
|
@Appsido the method "addAction" and maybe some others need public/open, too. |
|
@ltblueberry0 A lot of code change to make class + func public. @dillidon Do you eventually plan to merge the request once work done ? |
|
@dillidon When do you plan to pull this? |
|
@afshin-hoseini sure, I've just pull some updates and going to do this task... |
|
@dillidon seems you are not willing to merge my pull request. May I have your feedback why ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are ok with the cocoapods file you can just pusblish on cocoapods spec repos but before you do so, create a tag 1.0 of the repo
pod trunk push NAME.podspec