Behaviour of Graphql.Http.withCredentials in 1.5.0

[kyasu1]

After updating from 1.3.0 to 1.5.0 I got an CORS error. In 1.3.0 my request worked without Graphql.Http.withCredentials, but in 1.5.0 it fails and I need to add it in my request.

You are calling risky variants if withCredentials is False under the hood.

elm-graphql/src/Graphql/Http.elm

Lines 343 to 352 in 354e80b

	send : (Result (Error decodesTo) decodesTo -> msg) -> Request decodesTo -> Cmd msg
	send resultToMessage ((Request request) as fullRequest) =
	fullRequest
	|> toHttpRequestRecord resultToMessage
	|> (if request.withCredentials then
	Http.request
	else
	Http.riskyRequest
	)

If my understanding about withCredentials is correct, I think it should be reversed.

[dillonkearns]

Thank you so much for reporting this issue @kyasu1! I really appreciate it! Can't believe I mixed that up 🤦‍♂️

I just pushed a fix:

https://github.com/dillonkearns/elm-graphql/blob/master/CHANGELOG-ELM-PACKAGE.md#151---2018-12-01