Fix failing case of nested link references by making rawBlockParser recursive #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nkearns#60 (by adding a parse phase for container)
…rawBlockParser when a container is completed/close)
|
Since there is only a single test case in the CommonMark Spec nested link definitions, maybe we can add a few unit tests to get some more coverage and make sure it works for more complicated cases. I added this test module: e970820. That should be a good start, and the tests all pass 👍 We can add more test cases here if we think of any others. |
dillonkearns
reviewed
Jun 4, 2021
src/Markdown/Parser.elm
Outdated
| stepRawBlock : State -> Parser (Step State State) | ||
| stepRawBlock revStmts = | ||
| -- Some blocks can't immediately follow a body | ||
| oneOf | ||
| [ Helpers.endOfFile | ||
| |> map (\_ -> Done revStmts) | ||
| |> map (\_ -> Done (completeBlocks revStmts)) |
There was a problem hiding this comment.
If you change this to andThen, I believe you could use succeed and fail to pass through the parsed value or error. That would allow you to resolve your todo comment -- TODO return this error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exploration to solve the issue of nested link references #60 by using rawBlockParser recursively when a block container is completed/close.