Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefetch only links with content.json file available #37

Closed
synalysis opened this issue Jan 5, 2020 · 5 comments · Fixed by #60
Closed

Prefetch only links with content.json file available #37

synalysis opened this issue Jan 5, 2020 · 5 comments · Fixed by #60
Projects

Comments

@synalysis
Copy link
Sponsor Contributor

Currently all links going to the same site are prefetched which prevents links to downloadable files to work as well as <iframe> elements injected in Markdown files.

@dillonkearns dillonkearns added this to To prioritize in Roadmap Jan 5, 2020
@dillonkearns dillonkearns moved this from To prioritize to Prioritized in Roadmap Jan 26, 2020
@dillonkearns
Copy link
Owner

@synalysis would you mind trying out this branch to see if it solves the problem you were experiencing?

You can just git clone this repo, then

# cd into the repo
git checkout dont-preload-unknown-paths
npm install -g .

Would appreciate your insight on this!

@dillonkearns dillonkearns moved this from Prioritized to In progress in Roadmap Jan 28, 2020
@synalysis
Copy link
Sponsor Contributor Author

Works as designed - both <iframe> and download file 💪

@synalysis
Copy link
Sponsor Contributor Author

I noticed that when I open a subpage directly (or reload it), the start page is visible for a moment before the correct page is displayed. Don't know if this is a new issue.

It is not noticeable with the dev server but when installed on a web server. Both in Safari and Firefox the blinking start page can be observed: https://hexinator.com/order

@dillonkearns
Copy link
Owner

Fantastic, thank you for checking @synalysis! 🙏

That issue you're seeing is high on my list, this is the problem there: #52.

I'll get this released shortly 👍

@dillonkearns dillonkearns moved this from In progress to Ready for release in Roadmap Jan 29, 2020
@dillonkearns dillonkearns moved this from Ready for release to Released in Roadmap Jan 30, 2020
@dillonkearns
Copy link
Owner

This has been released with NPM package 1.2.3 and Elm package 3.0.1 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Roadmap
  
Released
Development

Successfully merging a pull request may close this issue.

2 participants