Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render empty shell for service worker navigation route (not root page) to prevent flash #52

Closed
dillonkearns opened this issue Jan 23, 2020 · 2 comments · Fixed by #55
Closed

Render empty shell for service worker navigation route (not root page) to prevent flash #52

dillonkearns opened this issue Jan 23, 2020 · 2 comments · Fixed by #55
Projects
Roadmap

Comments

@dillonkearns
Copy link
Owner

Right now when the service worker is registered and you open up an elm-pages site, it will load the root page's HTML and flash it briefly before the Elm code takes over. It should serve up the shell HTML (empty body) to use the shell service worker pattern: https://developers.google.com/web/fundamentals/architecture/app-shell.
This was referenced Jan 23, 2020
Closed
Merged
@dillonkearns dillonkearns reopened this Jan 24, 2020
@dillonkearns dillonkearns added this to Prioritized in Roadmap Jan 26, 2020
@dillonkearns dillonkearns mentioned this issue Jan 28, 2020
Closed
@dillonkearns dillonkearns moved this from Prioritized to Released in Roadmap Feb 3, 2020
@dillonkearns
Copy link
Owner Author

Fixed by https://github.com/dillonkearns/elm-pages/blob/master/CHANGELOG-NPM.md#126---2020-02-03.

@dillonkearns
Copy link
Owner Author

For now, it's just not rendering a shell at all except for offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Roadmap
  
Released
Milestone
No milestone
1 participant
@dillonkearns