-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try prerender-trigger event only after body has been updated to make sure Elm has rendered. #61
Conversation
…sure Elm has rendered.
5cf334f
to
5de7988
Compare
Hey 👋 I wanted to test this, but I'm getting the following error. Probably not because of this PR though? Error seems to come from
Installed using yarn with this package.json: {
"private": true,
"scripts": {
"dev": "elm-pages develop",
"build": "elm-pages build"
},
"devDependencies": {
"elm": "latest-0.19.1",
"elm-format": "^0.8.2",
"elm-git-install": "^0.1.2",
"elm-pages": "dillonkearns/elm-pages#prerender-trigger-after-view-function"
}
} |
Hmm, maybe try this? I'm not so familiar with that syntax, could be a yarn vs npm issue? |
Properly setup the `renderAfterDocumentEvent` option
Closing in favor of #62. |
@dillonkearns Um, so sorry, but, my PR was actually set to merge into this PR. So you should merge this one into master. No changes are in master now 👀 |
Whoops, I just saw that |
Released as NPM package version 1.2.4 👍 |
Fixes #40.