Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allows mail upto a certain length #12

Closed
Jaskaran2 opened this issue Oct 15, 2022 · 3 comments · Fixed by #28
Closed

Only allows mail upto a certain length #12

Jaskaran2 opened this issue Oct 15, 2022 · 3 comments · Fixed by #28
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Jaskaran2
Copy link

Describe the bug
While entering a mail if the mail is longer than a certain length it gets blocked. The max length being 25

To Reproduce
Steps to reproduce the behavior:

  1. Go to index page
  2. Enter a mail with more than 25 characters
@Dilshan-H
Copy link
Owner

The 25 character limit was introduced as it directly appears inside the cards (track list dashboard) and longer text may negatively effect the appearance of UI (like overflow in cards)
I guess it would be better if we can increase this character limit upto some count like 50 or 100 and handle the overflow issue in UI 🤔

For instance;

This is a sample text for title of an email

Will be shown as:

This is a sample text ...

It's basically shortening the entire title in cards.

@Jaskaran2
Copy link
Author

Yes I believe limit of 50 should be more than enough for it.

@Dilshan-H
Copy link
Owner

Yes I believe limit of 50 should be more than enough for it.

Sure, and implementing the title shortening on UI will fix this issue.

@Dilshan-H Dilshan-H added enhancement New feature or request good first issue Good for newcomers labels Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants