Handle missing input file explicitly #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for and raise an exception when the user passes a non-existing file as input. This makes such errors easier to identify, as opposed to the code path and exception that is raised with a non-existing file is passed (which also happens to be the same exception raised when a non-XLSX file is passed, making this error confusing).
|
@dilshod can this be merged? |
|
Did this ever get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a check for and raises an exception when the user passes a non-existing file as input. Without this PR, when the user passes a non-existing file this error is raised:
This is the same exception raised when a non-XLSX file is passed, making debugging a little confusing. This PR makes the situation clear.