This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
unifi.Device.SpeedTestStatus.Latency 5.8 API Fix #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to account for how the 5.8 Unifi Controller API returns the Latency.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dim13, I stumbled across your library while working on a project to pull time series data from Unifi devices. I only have a version 5.8 controller to test on and with your master branch, I wasn't able to unmarshal the unifi.Device.SpeedTestStatus.Latency field into a string (I'm assuming because of the type that is returned has changed between 5.7.x and 5.8.x versions of the API.) This should work with the 5.7 version of the API as float64 can account for decimals. This is my first pull request so let me know if you'd like me to change anything. I'll also look for other ways to help out and improve the library as I go. Thanks!