-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hint text to QueryRequestUIController #2668
Open
Charl1996
wants to merge
7
commits into
master
Choose a base branch
from
cs/SC-2367-show_hint_text
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
fee7e02
Add hint text to QueryRequestUIController
Charl1996 0321a91
wrap content
Charl1996 9ce5215
Remove wrapper class
Charl1996 16a3d80
Remove layout_weight
Charl1996 c964082
Merge branch 'master' into cs/SC-2367-show_hint_text
Charl1996 b217afe
Add test for hint button visibility
Charl1996 7bc07a9
Use constants
Charl1996 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ | |
import android.widget.LinearLayout; | ||
import android.widget.Spinner; | ||
import android.widget.TextView; | ||
import android.widget.ImageButton; | ||
|
||
import org.commcare.CommCareApplication; | ||
import org.commcare.CommCareTestApplication; | ||
|
@@ -217,6 +218,12 @@ public void reloadQueryActivityStateTest() { | |
EditText patientName = promptsLayout.getChildAt(0).findViewById(R.id.prompt_et); | ||
assertEquals("francisco", patientName.getText().toString()); | ||
|
||
ImageButton imageButtonWithoutHint = promptsLayout.getChildAt(0).findViewById(R.id.prompt_hint_button); | ||
assertEquals(8, imageButtonWithoutHint.getVisibility()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should use the constants from |
||
|
||
ImageButton imageButtonWithHint = promptsLayout.getChildAt(4).findViewById(R.id.prompt_hint_button); | ||
assertEquals(0, imageButtonWithHint.getVisibility()); | ||
|
||
Spinner stateSpinner = promptsLayout.getChildAt(2).findViewById(R.id.prompt_spinner); | ||
assertEquals(2, stateSpinner.getSelectedItemPosition()); | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to call
Localizer. processArguments
here as callingqueryPrompt.display.evaluate()
should evaluate any localised strings itself.