[Reminders app] Pass on logged in user ID to data update broadcast #2700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@damagatchi retest this please |
shubham1g5
requested changes
Oct 4, 2023
| // This is to be used to skip any cases that are not owned by the user but that might be | ||
| // in the database at the time of the data refresh | ||
| if (CommCareApplication.instance().getSession().isActive()) { | ||
| i.putExtra("logged-in-user-id", CommCareApplication.instance().getCurrentUserId()); |
There was a problem hiding this comment.
should this be cc-logged-in-user-id instead as per this PR ?
Comment on lines
25
to
26
| // This is to be used to skip any cases that are not owned by the user but that might be | ||
| // in the database at the time of the data refresh |
There was a problem hiding this comment.
reword to - Used by external apps to do any user based filtering
|
@shubham1g5 these comments were not visible to me, were they pending still on your end? |
|
yeah I only submitted them yesterday. |
shubham1g5
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes the current user ID in the data update broadcast. The goal is to prevent CommCare users from being notified over reminders they have sent to other users. There are also changes required on the Reminders app side that are in this PR.
Safety Assurance