Moves Async entity Implementation to Core #2732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plement an interface
3 tasks
|
bumping this for a review. |
snopoke
reviewed
Apr 8, 2024
avazirna
reviewed
Apr 8, 2024
| return detailId + "_" + mFieldId; | ||
| } | ||
|
|
||
| private static String buildValidKeys(Vector<Integer> sortKeys, DetailField[] fields) { |
There was a problem hiding this comment.
buildValidKeys, buildKeyNameWhereClause and populateEntitySet are private static methods called by non-static methods, do they need to be static?
There was a problem hiding this comment.
I prefer to make methods private static when they can be to signify that none of these methods changes the member variables of the class.
snopoke
reviewed
Apr 9, 2024
app/src/org/commcare/models/database/user/models/CommCareEntityStorageCache.java
Outdated
Show resolved
Hide resolved
snopoke
approved these changes
Apr 10, 2024
|
@damagatchi retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://dimagi-dev.atlassian.net/browse/USH-3790
Moves Async Entity to core in order to be able to implement Cache and Indexing feature on Web Apps.
Feature Flag
Cache and Index
Safety Assurance
Automated test coverage
No substantial coverage
Safety story
QA Note: Test Cache and Index functionality.
review commit by commit
cross-request: dimagi/commcare-core#1387