Allow Unsynced Time Limit to be set in hours #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@damagatchi retest this please |
OrangeAndGreen
previously approved these changes
Mar 1, 2024
mkangia
reviewed
Mar 1, 2024
| @@ -152,12 +152,13 @@ private static boolean unsentFormNumberLimitExceeded(int numUnsentForms) { | |||
|
|
|||
| private static boolean unsentFormTimeLimitExceeded(long lastSyncTime) { | |||
| SharedPreferences prefs = CommCareApplication.instance().getCurrentApp().getAppPreferences(); | |||
| int unsentFormTimeLimit = Integer.parseInt(prefs.getString(UNSENT_FORM_TIME_KEY, "5")); | |||
| double unsentFormTimeLimitInDays = Double.parseDouble(prefs.getString(UNSENT_FORM_TIME_KEY, "5")); | |||
| int unsentFormTimeLimitInMinutes = (int)(unsentFormTimeLimitInDays * 24 * 60); | |||
There was a problem hiding this comment.
How about converting this to seconds instead of minutes for even better precision?
There was a problem hiding this comment.
or miliseconds?
that way you avoid any conversion in the comparison later.
There was a problem hiding this comment.
I battled with the same question myself and ended up settling with minutes.
This makes it possible to set limits shorter than a day. The property Unsynced Time Limit is expressed in days, a decimal number will result in frequencies lower than 24 hours.
avazirna
force-pushed
the
allow-unsynced-time-limit-to-hours
branch
2 times, most recently
from
c851dfc
to
efd46d6
Compare
avazirna
force-pushed
the
allow-unsynced-time-limit-to-hours
branch
from
efd46d6
to
0e39881
Compare
mkangia
reviewed
Mar 4, 2024
|
|
||
| return minutesSinceLastSync > unsentFormTimeLimitInMinutes; | ||
| return msecsSinceLastSync > unsentFormTimeLimitInMsecs; |
OrangeAndGreen
approved these changes
Mar 4, 2024
shubham1g5
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the minimum frequency for CommCare to warn users that a sync is needed is daily, this PR allows setting time limits shorter than that. The property
Unsynced Time Limitis expressed in days, so this change makes it possible to pass down a decimal number resulting in frequencies lower than 24 hours, when the value is lower than1.Ticket: https://dimagi.atlassian.net/browse/SC-3223
Safety Assurance
Automated test coverage
Unit tests don't cover this logic. I was tempted to add some, but this code lives in a private method so I would need to broaden the scope of the test.