Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace production couch node 1 #6116

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

@dannyroberts dannyroberts force-pushed the dmr/replace-production-couch-node-1 branch from bf6d105 to 387d2a8 Compare September 12, 2023 15:59
@dannyroberts dannyroberts marked this pull request as ready for review September 12, 2023 16:48
@@ -0,0 +1,2 @@
target_allocation:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious what this file is used for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking a stab at answering this cause why not 😅 I believe we reference this migration file when running cchq ${ENV} migrate-couchdb ${PLAN_FILE} plan in phase 2 of adding this node. And then it looks like that file is used to allocate shards properly via couchdb-cluster-admin.

So then the syntax here is saying that we have three nodes and should make three copies of data across these nodes, which might be the same as saying 1 copy per node?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang Danny beat me to it haha

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but you said it better, Graham :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dannyroberts and @gherceg. That was super helpful :)

@AmitPhulera AmitPhulera merged commit ee4b88d into master Sep 26, 2023
2 checks passed
@AmitPhulera AmitPhulera deleted the dmr/replace-production-couch-node-1 branch September 26, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants