Add playbook to cleanup pg_repack on pgbouncer_a6 #6278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millerdev
approved these changes
May 21, 2024
Comment on lines
22
to
25
| - name: Display if pg_repack cron exists | ||
| debug: | ||
| msg: "pg_repack cron is configured" | ||
| when: pg_repack_cron.stat.exists == True |
There was a problem hiding this comment.
Nit: Is this task necessary? The next Remove pg_repack cron file task should tell you if it existed by its "changed" state.
There was a problem hiding this comment.
Nope was just useful for debugging. I removed the two tasks that are no longer needed. 9202b99
millerdev
approved these changes
May 27, 2024
dannyroberts
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dimagi.atlassian.net/browse/SAAS-15320
I don't have plans to merge this PR, but wanted to get it reviewed before running. As Danny noted here, we don't actually need to have pg_repack running on this database anymore since the entire point of partitioning this db is to make it easy to drop tables. The current working theory is that pg_repack runs are changing the table ownership to root, and making it impossible for our periodic celery task to drop these tables. After running this to disable pg_repack, we should be able to change the table ownership manually and have the celery task successfully drop tables again.
Environments Affected
Production