Updated Deliver Status View #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxwxnvermx
force-pushed
the
pkv/deliver-status-view-update
branch
from
4520966
to
751646a
Compare
pxwxnvermx
force-pushed
the
pkv/deliver-status-view-update
branch
from
4516371
to
f1483fd
Compare
calellowitz
approved these changes
May 7, 2024
| @@ -81,4 +81,5 @@ def get_annotated_opportunity_access_deliver_status(opportunity: Opportunity): | |||
| ) | |||
| .order_by("user__name") | |||
| ) | |||
| access_objects.sort(key=lambda a: a.user.name) | |||
There was a problem hiding this comment.
This is fine if necessary, but is it possible sort in sql?
There was a problem hiding this comment.
I tried to do the same query using SQL, to keep the sorting in SQL but ran into issues with payment units not showing up for users who have not submitted any forms, as no completed works were created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket