Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Visit API changes to Opportunity List API. #322

Merged
merged 3 commits into from
May 21, 2024

Conversation

pxwxnvermx
Copy link
Contributor

Ticket

Changes:

  • Opportunity List API now includes a new key payment_units which is an array of payment units for the opportunity.
payment_units: [
  {
    id: 1,
    name: "Payment Unit 1",
    total_max: 100,
    daily_max: 2
  }
]
  • Opportunity List API claim key updated to include information from different payment unit configurations for the user.
  • Note: the payment_unit key below is the payment_unit id.
"claim": {
      "max_payments": 200,
      "end_date": "2024-05-06",
      "date_claimed": "2024-04-12",
      "payment_units": [
        {
          "max_visits": 100,
          "payment_unit": 1
        },
        {
          "max_visits": 100,
          "payment_unit": 2
        }
      ]
 }

Copy link

@OrangeAndGreen OrangeAndGreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the most part everything looks good to me. One question: should the payment_units in the opportunity call also include the actual payment amount (i.e. 1000 MWK)? I don't think we're displaying that info in mobile yet but it sounds like we probably will be soon

@calellowitz calellowitz merged commit 80e638d into main May 21, 2024
2 checks passed
@calellowitz calellowitz deleted the pkv/multi-visit-api-changes branch May 21, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants