Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance improvement to fetching app data form CC #35

Merged
merged 7 commits into from
Jul 27, 2023

Conversation

snopoke
Copy link
Collaborator

@snopoke snopoke commented Jul 25, 2023

  • Fetch data in parallel (per domain)
  • Cache data to avoid re-fetching when saving the form

In future we may need a 'refresh' button to allow the user to update the app data in case they have made recent changes in CCHQ.

@snopoke snopoke requested a review from pxwxnvermx July 25, 2023 15:33
Copy link
Contributor

@pxwxnvermx pxwxnvermx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snopoke Thanks a lot for these improvements. 🥇

@snopoke snopoke merged commit f735ef0 into main Jul 27, 2023
2 checks passed
@snopoke snopoke deleted the sk/record-modules branch July 27, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants