Skip to content

Commit

Permalink
Merge c87011f into 70b95ef
Browse files Browse the repository at this point in the history
  • Loading branch information
ctsims committed May 17, 2020
2 parents 70b95ef + c87011f commit 6873ee7
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions commcare_export/writers.py
Expand Up @@ -272,6 +272,10 @@ def __exit__(self, exc_type, exc_val, exc_tb):
def is_postgres(self):
return 'postgres' in self.db_url

@property
def is_oracle(self):
return 'oracle' in self.db_url

@property
def is_mysql(self):
return 'mysql' in self.db_url
Expand All @@ -291,6 +295,8 @@ def max_column_length(self):
if self.is_mssql:
# https://docs.microsoft.com/en-us/sql/relational-databases/databases/database-identifiers?view=sql-server-2017
return 128
if self.is_oracle:
return 128
raise Exception("Unknown database dialect: {}".format(self.db_url))

@property
Expand Down Expand Up @@ -351,6 +357,8 @@ def best_type_for(self, val):
return sqlalchemy.UnicodeText(collation=self.collation)
elif self.is_mssql:
return sqlalchemy.NVARCHAR(collation=self.collation)
if self.is_oracle:
return sqlalchemy.UnicodeText(collation=self.collation)
else:
raise Exception("Unknown database dialect: {}".format(self.db_url))
else:
Expand Down

0 comments on commit 6873ee7

Please sign in to comment.