fix key error if meta.total_count is not present
#187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millerdev
approved these changes
Jun 22, 2021
proteusvacuum
approved these changes
Jun 22, 2021
tests/test_commcare_hq_client.py
Outdated
| @@ -154,7 +160,7 @@ def test_repeat_limit(self): | |||
| self._test_iterate(FakeRepeatedDateCaseSession(), get_paginator('case', 2), 2, [1, 2]) | |||
|
|
|||
| def test_message_log(self): | |||
| self._test_iterate(FakMessageLogSession(), get_paginator('messaging-event', 2), 2, [1, 2]) | |||
| self._test_iterate(FakMessageLogSession(), get_paginator('messaging-event', 2), 3, [1, 2, 3]) | |||
There was a problem hiding this comment.
is this a spelling mistake? I know this is what the class is called, but it reads a bit funny.
czue
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
messaging-eventsAPI does not include ameta.total_countfield.First commit is the fix - the rest are a minor refactor.