Include private dbs in shard migrations #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think I was misguided by initially excluding them. _global_changes, _replicator, and _users need to have their shards migrated like any other db
emord
approved these changes
Feb 8, 2019
snopoke
approved these changes
Feb 12, 2019
dannyroberts
force-pushed
the
dmr/include-private-dbs-in-shard-migrations
branch
from
d9bad97
to
1928439
Compare
emord
approved these changes
Feb 14, 2019
which are known to happen on the version of couch we are using to test
orangejenny
approved these changes
May 14, 2019
|
Tests passed but I rebased for a less ridiculous history
Hopefully it still passes 🤞 |
dannyroberts
force-pushed
the
dmr/include-private-dbs-in-shard-migrations
branch
from
b4f16a1
to
a6f247a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I was misguided by initially excluding them.
_global_changes, _replicator, and _users need to have their shards migrated
like any other db
Ran into this when removing the old couch nodes on prod. It didn't cause any service interruptions or anything, but I noticed those dbs were 500ing when I shut down the old nodes. After bringing them back up and re-running with these changes, I could shut the old nodes down no problem.