parse new <location/> metadata value

[dannyroberts]

No description provided.

[dannyroberts]

@czue tests pass, but should review carefully for correctness and/or things you think I should add a test for

[czue]

@dannyroberts no longer mergeable (sorry been delinquent)

[czue]

looks good though. curious whether you considered making a GeoPointProperty type of thing to hold the data versus keeping as a string (either way would be easyish to roll in later so am good with merging this once it's mergeable)

[dannyroberts]

Yeah, I don't have a clear philosophical or practical argument for or against doing something like GeoPointProperty. I guess the benefits are validation and ease of access to the data, so it seems like a positive. A danger incorrect validation code that crashes forms and prevents them from going through (like if we require something stricter than the full range of what the phone might send), but that's a short term thing that can be hotfixed as it comes, probably without irrecoverable damage, due to where it 500s.

[dannyroberts]

How's that?

[czue]

❌

[czue]

(and think you've correctly identified the tradeoffs and am happy with this outcome though would have been fine with either)

[dannyroberts]

✅