have case details ui fail gracefully when forms have no xml attachments #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| return self[const.TAG_XML] | ||
| except AttributeError: | ||
| return None |
There was a problem hiding this comment.
sort of surprised this is AttributeError and not KeyError - i guess some couchdbkit hackery?
There was a problem hiding this comment.
yeah, it throws the same exception whether you do self[key] or self.key
czue
added a commit
that referenced
this pull request
May 23, 2013
have case details ui fail gracefully when forms have no xml attachments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up while I was testing bihar reports locally, as my copy_group_data mgmt cmd doesn't copy attachments.
Anyway, thought it might come in handy.