Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace couch update handler (xml2json) with python implementation #71

Merged
merged 11 commits into from
Dec 21, 2013
Merged

Replace couch update handler (xml2json) with python implementation #71

merged 11 commits into from
Dec 21, 2013

Conversation

dannyroberts
Copy link
Member

No description provided.

@dannyroberts dannyroberts mentioned this pull request Oct 12, 2013
Closed
@czue
Copy link
Member

czue commented Oct 12, 2013

this is awesome.

@czue czue closed this Oct 12, 2013
@dannyroberts
Copy link
Member Author

Thanks yeah. I didn't get all the hq tests to pass last night so there must be done outstanding issues, but it mostly just went pretty smoothly.

@dannyroberts
replace couchd update handler with simple python equivalent
77f1cfa
@dannyroberts
delete now-unused _design updates/utils
2ce5aae
@dannyroberts
add xml2json to travis requirements
b16e043
@dannyroberts
fix tests to call the interface
6ca6496 
instead of the update handler which has been removed
@dannyroberts
improve interface and minor cleanup
0377832 
change name of post_from_settings to create_xform_from_xml
and expose as couchforms.create_xform_from_xml
@dannyroberts
raise explicit exception for invalid form xml
bc11ab2 
- new exception couchforms.XMLSyntaxError
  (Didn't just let the lxml error bleed through because
  that would be tying the API to an implemenation detail.)
- add short docstring indicating exception raised
@dannyroberts
fix catching of xml syntax error
2742b56 
refactor to use xml2json (python) broke the exception chain
moved piece of code written for this to the correct new place
@dannyroberts
be tolorant of form with no top-level xmlns set
346f459
@dannyroberts
change remote location of xml2json
350fe66
@dannyroberts
Merge branch 'master' into replace-update
7fbcb2b 
Conflicts:
	couchforms/__init__.py
	couchforms/util.py
@dannyroberts
Copy link
Member Author

Forwarded forms for a project for a week to staging (about 600 forms), compared forms on staging and www. Diff includes only the following properties:

_rev
app_id
last_sync_token
submit_ip
openrosa_headers
path
received_on
date_header
(HTTP_.*)

Feeling pretty confident now.

@dannyroberts dannyroberts reopened this Dec 20, 2013
@czue
Copy link
Member

czue commented Dec 20, 2013

holy canoli!

czue
czue reviewed Dec 20, 2013
View reviewed changes
couchforms/util.py
settings.COUCH_USERNAME,
settings.COUCH_PASSWORD)

def _extract_meta_instance_id(form):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should use this function in _handle_id_conflict to get the id out

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, done

czue added a commit that referenced this pull request Dec 21, 2013
@czue
Merge pull request #71 from dimagi/replace-update
3ae5780 
Replace couch update handler (xml2json) with python implementation
@czue czue merged commit 3ae5780 into master Dec 21, 2013
@czue czue deleted the replace-update branch December 21, 2013 00:16
@dmyung
Copy link
Contributor

dmyung commented Dec 21, 2013

it's finally happened? yay!

@dannyroberts
Copy link
Member Author

Hell yeah it has!

@dannyroberts dannyroberts mentioned this pull request Jan 6, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dannyroberts @czue @dmyung