remove error handling that never worked and fix imports #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| bad = XFormError.get(doc_id) | ||
| bad.problem = unicode(e) | ||
| bad.save() | ||
| return bad |
There was a problem hiding this comment.
can you explain how this wasn't working?
| from couchforms.signals import xform_saved | ||
| from dimagi.utils.couch import uid | ||
| import re | ||
| from restkit.errors import ResourceNotFound |
There was a problem hiding this comment.
The only API change should be that fetch_and_wrap_form (below) should now raise couchdbkit.exceptions.ResourceNotFound instead of restkit.errors.ResourceNotFound. I'll change this where it's called.
czue
added a commit
that referenced
this pull request
Feb 19, 2014
remove error handling that never worked and fix imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.