Fixes #56: Support for Django 3. Added envs in travis for python 3.7, 3.8 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 4, 2020 11:43
…i for python 3.7 and 3.8 * Updated setup.py to allow django 3 while still excluding versions referenced in: GHSA-hmr4-m2h5-33qx * Added py3.7 and py3.8 support to .travis.yml * Django 3 took out the need for python_2_unicode_compatible as can be seen in other large django packages. Lef as a version switch for backwards compatibility. * Django 3 changed the signature of from_db_value and removed the context parameter as a positional arg. The old code never used it anyhow so this change should work and is also the recommended change from looking at other Django packages Ran through all the tests manually for each python environment and everything passed.
dannyroberts
reviewed
Aug 4, 2020
setup.py
Outdated
| # https://github.com/advisories/GHSA-hmr4-m2h5-33qx | ||
| 'django>=1.11.28,!=2.0.*,!=2.1.*,!=2.2.0,!=2.2.1,!=2.2.2,!=2.2.3,!=2.2.4,!=2.2.5,!=2.2.6,!=2.2.7,!=2.2.8,!=2.2.9,<3', | ||
| 'django>=1.11.28,!=2.0.*,!=2.1.*,!=2.2.0,!=2.2.1,!=2.2.2,!=2.2.3,!=2.2.4,!=2.2.5,!=2.2.6,!=2.2.7,!=2.2.8,!=2.2.9,!=3.0.0,!=3.0.1,!=3.0.2', |
There was a problem hiding this comment.
I think we'll still need a <4 here so that when it comes out in the future, it's not retroactively considered a valid version (until we support it).
millerdev
reviewed
Aug 4, 2020
There was a problem hiding this comment.
@stgraham2000 Thank you for the contribution!
Please remove Pipfile and Pipfile.lock from this PR. They may be added a separate PR with an explanation of why they are important if you think they are an improvement.
* Removed Pipfile and Pipfile.lock that were accidentally added in a previous commit * Changed setup.py to restrict untested major versions of Django
millerdev
approved these changes
Aug 4, 2020
|
Thanks Daniel. Oops about the Pipfile.* checkins. They slipped in during one of my 2 commits to fix the build. |
|
@stgraham2000 version 1.0.0, which includes this change-set has been uploaded to pypi, fyi |
|
Cheers!
I guess my timing was good 👍
I’m looking forward to using this package. Let me know if there is anything I can do to help.
On Aug 4, 2020, at 7:23 PM, Daniel Miller <notifications@github.com> wrote:
@stgraham2000 version 1.0.0, which includes this change-set has been uploaded to pypi, fyi
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran through all the tests manually for each python environment and everything passed.