USH-4497: Do not append domain to username with @ #1579
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1579 +/- ##
============================================
- Coverage 70.41% 70.39% -0.02%
Complexity 2009 2009
============================================
Files 251 251
Lines 7797 7799 +2
Branches 711 711
============================================
Hits 5490 5490
- Misses 2037 2038 +1
- Partials 270 271 +1 ☔ View full report in Codecov by Sentry. |
|
@shubham1g5 the function I changed is called twice. Once in the menu session, which is where the username for the claim case request comes from. And the second time in the RestoreFactory. I could not figure out when that code gets called and if the change would be appropriate there or if I should move the check. |
That usage looks harmless as the code that calls it is only getting used for logging without any affect on business logic. |
| @@ -9,6 +9,9 @@ public static String getFullUsername(String user, String domain, String host) { | |||
| } | |||
|
|
|||
| public static String getFullUsername(String user, String domain) { | |||
| if (user.contains("@")) { | |||
There was a problem hiding this comment.
since this method is only overloading the method before this, this change should actually be made in the previous method.
There was a problem hiding this comment.
You mean in MenuSession.getNextScreen correct?
There was a problem hiding this comment.
no there is another getFullUsername method that this method calls.
|
Q: Can't a Mobile worker name be like - |
|
A: No they cannot. If you try using an @ during creation you get a validation error. |
* Users now can login as web users which already have the complete username used for couch. Do not append domain and host it that case
MartinRiese
force-pushed
the
riese/web_user_name
branch
from
11e15b8
to
52427cf
Compare
Technical Summary
https://dimagi.atlassian.net/browse/USH-4497
Users now can login as web users which already have the complete username used for couch. Do not append domain and host it that case. Without this change the claim-case request has a non-existing username in the body and will fail silently.
We do the same in hq: https://github.com/dimagi/commcare-hq/pull/34351/files#diff-b5520648dffd5a4f57530e5e1c36f90cd022db2cbf59bfef9bb3d65997d6f316R64-R74
Safety Assurance
Safety story
Automated test coverage
QA Plan
Special deploy instructions
Rollback instructions
Review