-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix column keys so that query grouping works #44
Conversation
self.table_name, | ||
tuple(sorted(self.filters)) if self.filters else None, | ||
tuple(self.group_by) if self.group_by else None | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the main change along with the implementation of correct hashing and comparison for the filter classes
return hash((RawFilter, self.expression)) | ||
|
||
def __repr__(self): | ||
return "SQL({})".format(self.expression) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for debugging
For the |
I used |
Previously the following query would result in 2 SQL queries instead of 1 because the column key hash did not work: