feat: Remove unnecessary Promise use #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
description: currently the api call 3 nested Promise use into one another, in which one is completely unecessary, there is no need of promise creation in admin/index.js, customer/index.js, guest/index.js We can simply reuse promise return from magento/index.js in functions written in admin, guest and customer
dimaportenko
approved these changes
Jul 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
description: currently the api call 3 nested Promise use into one another, in which one is completely unecessary,
there is no need of promise creation in admin/index.js, customer/index.js, guest/index.js
We can simply reuse promise return from magento/index.js in functions written in admin, guest and customer
Does this close any currently open issues?
#64
Any other comments?
This pull request requires complete Testing, to make sure all API are working properly.
Where has this been tested?