Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParamsContextKey is now an unexported value of an unexported type #53

Merged
merged 2 commits into from
Jun 21, 2017

Conversation

dimfeld
Copy link
Owner

@dimfeld dimfeld commented Jun 21, 2017

Fixes #50

context.go Outdated
return p
}
return map[string]string{}
}

// ParamsContextKey is used to retrieve a path's params map from a request's context.
const ParamsContextKey = "params.context.key"
// paramsContextKey is used to retrieve a path's params map from a request's context.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should go with the const value

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Thanks!

@dimfeld dimfeld merged commit c50d96a into master Jun 21, 2017
@dimfeld dimfeld deleted the private_context_key branch June 21, 2017 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant