Make ContextData() available to middleware #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should have a chance to look at this tonight or tomorrow. Thank you! |
ninthclowd
force-pushed
the
master
branch
3 times, most recently
from
291a981
to
d88fe47
Compare
add test for retrieving context data in middleware
|
Ok sorry about the additional commits. I added a test that will fail if ContextData is not available in the middleware layer. |
|
In order to keep compatibility with really old Go versions, and to reduce allocations for people who are using the old-style handlers and don't want Context, I moved things around a bit. I made a new PR, #82, which has the code. If that looks ok to you then I think this is good to go. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks a lot for httptreemux! Solid router :)
This commit populates the context data after the middleware has all been added to the handler, instead of before. This makes the Context* functions available for use in all middleware, addressing #73.