Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does from_array_.. methods take self? #45

Closed
bvssvni opened this issue Nov 24, 2014 · 1 comment
Closed

Why does from_array_.. methods take self? #45

bvssvni opened this issue Nov 24, 2014 · 1 comment

Comments

@bvssvni
Copy link

bvssvni commented Nov 24, 2014

I was looking for a way to convert [f32, ..2] into a Vec2<f32> when I found this:

https://github.com/sebcrozet/nalgebra/blob/b1a58e9ebeda6ab8374ef5388e122b11374391a0/src/structs/vec_macros.rs#L44

Is there any reason to take self?
@sebcrozet
Copy link
Member

You're right, there should not be any self there. Looks like a copy/paste mistake!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebcrozet @bvssvni