Skip to content
This repository has been archived by the owner on Oct 14, 2021. It is now read-only.

fix: check permission downloading excel file in management #169

Merged
merged 10 commits into from
Mar 24, 2019
Merged

fix: check permission downloading excel file in management #169

merged 10 commits into from
Mar 24, 2019

Conversation

taevel02
Copy link
Member

@taevel02 taevel02 commented Mar 18, 2019 •
edited
Loading

Closes #54

@dimigo-din dimigo-din deleted a comment Mar 18, 2019
@dimigo-din dimigo-din deleted a comment Mar 18, 2019
@junhoyeo
Copy link
Member

junhoyeo commented Mar 18, 2019 •
edited
Loading

Closing multiple issues에 의거하여 이슈 본문 수정했습니다.

@taevel02 taevel02 changed the title fix: check permission downloading excel file in management and add ui feedback of downloads fix: check permission downloading excel file in management Mar 22, 2019
@taevel02 taevel02 requested a review from a team March 23, 2019 12:45
@dimigo-din dimigo-din deleted a comment Mar 23, 2019
@taevel02 taevel02 added this to In progress in Busy March (2019 Q1) via automation Mar 23, 2019
@taevel02 taevel02 moved this from In progress to Needs review in Busy March (2019 Q1) Mar 23, 2019
@dimigo-din dimigo-din deleted a comment Mar 23, 2019
@dimigo-din dimigo-din deleted a comment Mar 23, 2019
Busy March (2019 Q1) automation moved this from Needs review to Reviewer approved Mar 24, 2019
uhmseohun
uhmseohun previously approved these changes Mar 24, 2019
View reviewed changes
app/src/api/counsel/counsel.service.js Show resolved Hide resolved
app/src/api/dets/dets.service.js Show resolved Hide resolved
app/src/api/ingang/ingang.service.js Outdated Show resolved Hide resolved
@uhmseohun
Copy link
Member

실수로 approved로 됬어요ㅜㅜ

@uhmseohun uhmseohun self-requested a review March 24, 2019 01:36
@uhmseohun uhmseohun removed their request for review March 24, 2019 01:43
@dimigo-din dimigo-din deleted a comment Mar 24, 2019
fix(payload): change api payload
fb611dc 
원래 페이로드 `/ingang`인데 `/ingangs`로 되있었음
Busy March (2019 Q1) automation moved this from Reviewer approved to Needs review Mar 24, 2019
@dimigo-din dimigo-din deleted a comment Mar 24, 2019
@dimigo-din dimigo-din deleted a comment Mar 24, 2019
@uhmseohun uhmseohun requested a review from a team March 24, 2019 04:37
@uhmseohun uhmseohun mentioned this pull request Mar 24, 2019
Open
@dimigo-din dimigo-din deleted a comment Mar 24, 2019
@dimigo-din dimigo-din deleted a comment Mar 24, 2019
@seompark
Copy link
Member

리버트해주세요. 인강실 관련은 제가 리펙토링 중이에요. 이 pr에서는 #54 이슈만 생각합니다. 본인에게 할당된 다른 이슈를 고쳐주세요.

리팩토링 중이면 이렇게 혼동되지 않게 바로 PR을 올려주세요

@uhmseohun uhmseohun merged commit 62dbbcd into master Mar 24, 2019
Busy March (2019 Q1) automation moved this from Needs review to Done Mar 24, 2019
@uhmseohun uhmseohun deleted the fix-download-feedback branch March 24, 2019 11:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@seompark seompark seompark left review comments

@junhoyeo junhoyeo junhoyeo left review comments

@uhmseohun uhmseohun uhmseohun left review comments

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Busy March (2019 Q1)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taevel02 @junhoyeo @uhmseohun @seompark