Some perf improvement #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebKit support GPU acceleration when using WebKit transform with 3D transforms. This patch use WebKit Transform when possible in order to improve the performance when moving the tiles.
The branch if(!useBlankImage) is always taken since useBlankImage was assigned just above. Move useBlankImage, tileImgId and src to improve the span of those variables.
If the final size is equal to the natural size, forcing the size with CSS is useless. Since the style is not shared here, that was just wasting memory and adding complexity.
To avoid re-rendering the ThumbnailControl all the time, the navigation rect is moved through CSS transform.
Loading images could stay in the well and polute the tree. This patch ensure everything is cleared before recreating the tiles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hacked a couple of patches while looking into performance.
Everything might not be correct but I figured some of it might be worth sharing.
In the end, I think the implementation would have to be a lot more aggressive to achieve 60FPS on desktop and mobile devices.