fix el-get-remove-autoloads for emacs != 24.3 #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of tricking autoload-find-destination to do what we want, pull out the relevant bits of code that do removal. Using autoload-find-destination works in emacs 24.3 apparently because of a bug: file-attributes returns a 4 integer list for time, but the autoload function expects the old 2 integer format. In 24.2 where file-attributes still returns 2 integers, the autoload section is considered up to date and is not removed.
|
This is good, I also tested, Merged. |
yyr
added a commit
that referenced
this pull request
Dec 13, 2013
fix el-get-remove-autoloads for emacs != 24.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of tricking
autoload-find-destinationto do what we want, pullout the relevant bits of code that do removal.
Using
autoload-find-destinationworks in emacs 24.3 apparently becauseof a bug: file-attributes returns a 4 integer list for time, but the
autoload function expects the old 2 integer format. In 24.2 where
file-attributesstill returns 2 integers, the autoload section isconsidered up to date and is not removed.
This fixes #446 for emacs older than 24.3. I've tested (
./run-test.sh 446) with 23.4, 24.2, and 24.3.