Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapping of getutcdate ms sql default function #1466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bjrne
Copy link

@bjrne bjrne commented Feb 17, 2023

getdate() is getutcdate() under the hood, but getutcdate() can also be used and thus also needs a mapping/translation

Thanks for this awesome open source software!

getdate() is getutcdate() under the hood, but getutcdate() can also be used and thus also needs a mapping/translation
@axtox
Copy link

axtox commented Feb 5, 2024

Hey, any news on that? I have this issue - our database uses getutcdate() all over the place so it's good to have this fix in latest release, because it's easier to use pgloader with docker

I'm new to pgloader, reading through documentation currently, hope I could at least use loader script to address this issue, but this feature is good to have.

And I believe that default getdate() should be translated to LOCALTIMESTAMP

Also adding missing SYSUTCDATETIME and SYSDATETIME might be a good point, they return datetime2 format which range is still included in PostgreSQL timestamp with time zone type so basically can be safely translated to the same CURRENT_TIMESTAMP and LOCALTIMESTAMP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mssql drop default or change default of timestampz columns
2 participants